install build-essential to compile dependencies and use multi-stage build #2582
Merged
JelleZijlstra merged 4 commits intopsf:mainfrom Nov 1, 2021
Merged
install build-essential to compile dependencies and use multi-stage build #2582JelleZijlstra merged 4 commits intopsf:mainfrom
JelleZijlstra merged 4 commits intopsf:mainfrom
Conversation
- Install build-essential to avoid build issues like psf#2568 when dependencies don't have prebuilt wheels available - Use multi-stage build instead of trying to purge packages and cache from the image Copying `/root/.local/` installs only black's built Python dependencies (< 20 MB). So the image is barely larger than python:3-slim base image
cooperlees
approved these changes
Nov 1, 2021
Collaborator
cooperlees
left a comment
cooperlees
left a comment
There was a problem hiding this comment.
Awesome, thanks! Nice use of --user to get all the artifacts in an easy place to copy.
JelleZijlstra
pushed a commit
that referenced
this pull request
Nov 16, 2021
…build (#2582) - Install build-essential to avoid build issues like #2568 when dependencies don't have prebuilt wheels available - Use multi-stage build instead of trying to purge packages and cache from the image Copying `/root/.local/` installs only black's built Python dependencies (< 20 MB). So the image is barely larger than python:3-slim base image
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
regexpinned version: not necessary as we can build from source if wheels are missingCopying
/root/.local/installs only black's built Python dependencies (< 20 MB).So the image is barely larger than python:3-slim base image
Tested locally and in my fork GitHub Actions: https://github.com/vbarbaresi/black/runs/4062490765?check_suite_focus=true