Skip to content

Comments

Fix feature detection for positional-only arguments in lambdas#2532

Merged
JelleZijlstra merged 2 commits intopsf:mainfrom
Zac-HD:fix-version-detection
Oct 12, 2021
Merged

Fix feature detection for positional-only arguments in lambdas#2532
JelleZijlstra merged 2 commits intopsf:mainfrom
Zac-HD:fix-version-detection

Conversation

@Zac-HD
Copy link
Contributor

@Zac-HD Zac-HD commented Oct 12, 2021

Description

While working on shed, I discovered that feature detection for positional-only arguments doesn't work in lambdas, though the docstring of get_features_used() suggests that it should. I've therefore added syms.varargslist to the check, and a test case which demonstrates that it works.

Checklist

  • Added a CHANGELOG entry
  • Added test cases
  • This change does not need documentation

@Zac-HD Zac-HD force-pushed the fix-version-detection branch from 93e8c45 to 2f1f066 Compare October 12, 2021 00:53
@ghost
Copy link

ghost commented Oct 12, 2021 via email

@JelleZijlstra JelleZijlstra merged commit 2f3fa1f into psf:main Oct 12, 2021
@Zac-HD Zac-HD deleted the fix-version-detection branch October 12, 2021 05:12
@Zac-HD
Copy link
Contributor Author

Zac-HD commented Oct 12, 2021

Shed? It's not black anymore?

https://github.com/Zac-HD/shed is my downstream autoformatter; it includes Black but also wraps tools like isort and some custom refactoring logic.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants