Merged
Conversation
ktlim
reviewed
Aug 23, 2021
fb60095 to
8a641b1
Compare
8a641b1 to
3b151f4
Compare
ichard26
approved these changes
Aug 23, 2021
Collaborator
ichard26
left a comment
There was a problem hiding this comment.
Ah yeah this makes sense. Thanks for the PR!
zsol
approved these changes
Aug 24, 2021
Collaborator
zsol
left a comment
There was a problem hiding this comment.
Lgtm, just one minor comment
Collaborator
|
Not waiting for all of primer since the chance of them uncovering an issue here is extremely low. |
Collaborator
|
Hey thanks for your contribution! This project is only possible by contributions like these 🖤. You're awesome, @erykoff, never really thought about how a sys.exit would be problematic on import (not sure why, but eh who cares :p). If you have any suggestions about your contributing experience here, please let us via #2238, thank you once again! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The fix for #1688 in #1761 breaks
help("modules")introspection and also leads to unhappy results when inadvertently importingblackdfrom python. E.g.:(Notice that python has been exited).
This PR changes the
sys.exit(-1)in theimportcode to a properRaise.