Accept empty stdin (close #2337)#2346
Merged
Conversation
felix-hilden
approved these changes
Jun 22, 2021
Collaborator
felix-hilden
left a comment
felix-hilden
left a comment
There was a problem hiding this comment.
Thanks a bunch! The change itself looks good, and the command line result is completely fine without the newline. I left a small nitpick below, but feel free to ignore it!
Collaborator
|
Could you also write a change log entry? I think this is worth notifying users. |
Collaborator
|
Thanks for the fast turnaround, LGTM! |
ichard26
approved these changes
Jun 23, 2021
Collaborator
ichard26
left a comment
ichard26
left a comment
There was a problem hiding this comment.
LGTM! Thanks a lot for the quick patch, it's well appreciated 🖤
JelleZijlstra
approved these changes
Jun 23, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix #2337: Now Black does not fail for empty stdin file 👍