Use level 4 by default and level info instead of suppress#881
Merged
Use level 4 by default and level info instead of suppress#881
Conversation
exclude tests dir by default as it requires other Psalm plugins plus makes dead code detection less usable
exclude tests dir by default as it requires other Psalm plugins plus makes dead code detection less usable
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adjusts the generated psalm.xml defaults produced by the init CLI command to be less strict/noisy out of the box for Laravel projects, and to avoid analyzing the tests/ directory by default.
Changes:
- Change the default Psalm
errorLevelused byinitfrom 3 to 4. - Update multiple issue handlers in the generated config from
errorLevel="suppress"toerrorLevel="info"(and addImplicitToStringCastasinfo). - Exclude the
tests/directory by default in the generated config (with an inline note about optional PHPUnit/Mockery plugins).
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| tests/Unit/Cli/InitCommandTest.php | Updates assertions to reflect the new default error level and issue handler severities. |
| src/Cli/InitCommand.php | Updates the psalm.xml template defaults (error level, ignored paths, issue handler levels). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| $this->assertStringContainsString('<pluginClass class="Psalm\\LaravelPlugin\\Plugin"/>', $contents); | ||
| $this->assertStringContainsString('<directory name="vendor"/>', $contents); | ||
| $this->assertStringContainsString('<directory name="storage"/>', $contents); | ||
| $this->assertStringContainsString('<directory name="bootstrap/cache"/>', $contents); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Exclude tests dir by default as it requires other Psalm plugins plus makes dead code detection less usable.