Skip finding binary location when SLIC3R_FHS is enabled#15242
Open
renatoaguiar wants to merge 1 commit intoprusa3d:masterfrom
Open
Skip finding binary location when SLIC3R_FHS is enabled#15242renatoaguiar wants to merge 1 commit intoprusa3d:masterfrom
renatoaguiar wants to merge 1 commit intoprusa3d:masterfrom
Conversation
The path_to_binary variable is not used when SLIC3R_FHS is enabled, so this its declaration can be skipped.
renatoaguiar
force-pushed
the
skip-querying-binary-location-when-fhs-is-enabled
branch
from
19b2221 to
fcb5894
Compare
renatoaguiar
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The path_to_binary variable is not used when SLIC3R_FHS is enabled, so this its declaration can be skipped.
This eliminates an unnecessary call to
boost::dll::program_location().