Add advanced fuzzy skin features ported from OrcaSlicer#15229
Open
holdenkilbride wants to merge 3 commits intoprusa3d:masterfrom
Open
Add advanced fuzzy skin features ported from OrcaSlicer#15229holdenkilbride wants to merge 3 commits intoprusa3d:masterfrom
holdenkilbride wants to merge 3 commits intoprusa3d:masterfrom
Conversation
Port OrcaSlicer's enhanced fuzzy skin implementation adding: New noise types: - Perlin: smooth, natural-looking patterns - Billow: cloud-like billowy patterns - RidgedMulti: sharp ridge patterns - Voronoi: cell-like patterns - Classic: original random behavior (default) New modes: - Displacement: offset points perpendicular to wall (original) - Extrusion: vary extrusion width (requires Arachne) - Combined: both displacement and width variation New options: - AllWalls fuzzy skin type: fuzzify internal perimeters too - First-layer toggle: control bed adhesion vs aesthetics - Noise scale, octaves, persistence parameters Implementation: - Vendor libnoise library via deps/ system (LGPL-2.1+) - Add slice_z to PerimeterGenerator for 3D noise sampling - GUI shows/hides options based on relevance - Arachne compatibility check for width-varying modes
Test coverage includes: - should_fuzzify() logic for all FuzzySkinType variants (None, External, All, AllWalls) - First layer option behavior - fuzzy_polygon() with all 5 noise types (Classic, Perlin, Billow, RidgedMulti, Voronoi) - fuzzy_extrusion_line() with all 3 modes (Displacement, Extrusion, Combined) - Coherent noise pattern consistency across Z heights - apply_fuzzy_skin() with empty perimeter regions - Integration tests slicing a cube with various fuzzy skin configurations All 84 assertions pass across 6 test cases.
Port OrcaSlicer's enhanced fuzzy skin implementation adding:
New noise types:
Perlin: smooth, natural-looking patterns
Billow: cloud-like billowy patterns
RidgedMulti: sharp ridge patterns
Voronoi: cell-like patterns
Classic: original random behavior (default)
New modes:
Displacement: offset points perpendicular to wall (original)
Extrusion: vary extrusion width (requires Arachne)
Combined: both displacement and width variation
New options:
AllWalls fuzzy skin type: fuzzify internal perimeters too
First-layer toggle: control bed adhesion vs aesthetics
Noise scale, octaves, persistence parameters
Implementation:
Vendor libnoise library via deps/ system (LGPL-2.1+)
Add slice_z to PerimeterGenerator for 3D noise sampling
GUI shows/hides options based on relevance
Arachne compatibility check for width-varying modes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Port OrcaSlicer's enhanced fuzzy skin implementation adding:
New noise types:
New modes:
New options:
Implementation: