Skip to content

bugfix / unable to login on ubuntu 24.04 / fixes #14356 #15164

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
thefnordling wants to merge 2 commits into
base: master
Choose a base branch
from
+24 −2
Open

bugfix / unable to login on ubuntu 24.04 / fixes #14356 #15164

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5ab7576
prevent non-critical page errors from interrupting login workflow
thefnordling Jan 19, 2026
a211cad
remove some temporary diagnostic loggin from the fix
thefnordling Jan 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 12 additions & 1 deletion src/slic3r/GUI/ConfigWizardWebViewPage.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,7 +94,18 @@ case type: \
}

BOOST_LOG_TRIVIAL(error) << "ConfigWizardWebViewPage error: " << category;
load_error_page();

// Don't treat wxWEBVIEW_NAV_ERR_OTHER as fatal - it often occurs for subresources
// or cancelled requests while the main page continues loading successfully.
// Only show error page for serious errors like connection or certificate failures.
int err = evt.GetInt();
if (err == wxWEBVIEW_NAV_ERR_CONNECTION ||
err == wxWEBVIEW_NAV_ERR_CERTIFICATE ||
err == wxWEBVIEW_NAV_ERR_AUTH ||
err == wxWEBVIEW_NAV_ERR_SECURITY) {
load_error_page();
}
// For wxWEBVIEW_NAV_ERR_OTHER, wxWEBVIEW_NAV_ERR_REQUEST, etc. - just log and continue
}

void ConfigWizardWebViewPage::load_error_page() {
Expand Down
13 changes: 12 additions & 1 deletion src/slic3r/GUI/WebViewDialog.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -418,7 +418,18 @@ case type: \
}

BOOST_LOG_TRIVIAL(error) << "WebViewDialog error: " << category;
load_error_page();

// Don't treat wxWEBVIEW_NAV_ERR_OTHER as fatal - it often occurs for cancelled
// subresource requests while the main page continues loading successfully.
// Only show error page for serious errors like connection or certificate failures.
int err = evt.GetInt();
if (err == wxWEBVIEW_NAV_ERR_CONNECTION ||
err == wxWEBVIEW_NAV_ERR_CERTIFICATE ||
err == wxWEBVIEW_NAV_ERR_AUTH ||
err == wxWEBVIEW_NAV_ERR_SECURITY) {
load_error_page();
}
// For wxWEBVIEW_NAV_ERR_OTHER, wxWEBVIEW_NAV_ERR_REQUEST, etc. - just log and continue
}

void WebViewDialog::load_error_page()
Expand Down