Fix unable to type in search bar on Windows#15148
Open
cobryan05 wants to merge 1 commit intoprusa3d:masterfrom
Open
Fix unable to type in search bar on Windows#15148cobryan05 wants to merge 1 commit intoprusa3d:masterfrom
cobryan05 wants to merge 1 commit intoprusa3d:masterfrom
Conversation
TopBar's 'left click' handler triggers a search, but also calls 'event.Skip()' which allows other handlers to run. There appear to be no other wxWidget handlers bound to this event, but calling 'Skip' allows the event to make it the default CallWindowProc() call. It appears that on Windows 11 on a DPI-scaling enabled monitor that both handling AND Skipping this event causes the search box to spaz out. Simply removing the 'Skip' prevents Windows from double-handling the event.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TopBar's 'left click' handler triggers a search, but also calls 'event.Skip()' which allows other handlers to run. There appear to be no other wxWidget handlers bound to this event, but calling 'Skip' allows the event to make it the default CallWindowProc() call.
It appears that on Windows 11 on a DPI-scaling enabled monitor that both handling AND Skipping this event causes the search box to spaz out. Simply removing the 'Skip' prevents Windows from double-handling the event.
Should close #14131 #14828 #15137