version 2.9.4 git: prevent o-length segments from tripping multiple assertions when viewing layers in vase mode#15142
Open
themanyone wants to merge 4 commits intoprusa3d:masterfrom
Open
version 2.9.4 git: prevent o-length segments from tripping multiple assertions when viewing layers in vase mode#15142themanyone wants to merge 4 commits intoprusa3d:masterfrom
themanyone wants to merge 4 commits intoprusa3d:masterfrom
Conversation
added 4 commits
January 10, 2026 13:11
… to fail in vase mode
prevents crash when vewing vase layers in plater
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #13739
Optimized if statement so functional operation appears on right-hand side of the
||That way, faster == checks are performed first and function doesn't operate on 0-length lines.
That prevented some assertions but CoolingBuffer was still trying to process some empty gcode, which is worked-around by skipping empty lines.
Added a bounds check to DoubleSliderForLayers.cpp so operating the slider doesn't crash plater on bottom layer.
Finally, replaced two assertions in Polyline.cpp with if statements to prevent crash when trying to rotate the view.