fix(azure): remove duplicated findings in entra_user_with_vm_access_has_mfa#9914
Merged
HugoPBrito merged 3 commits intomasterfrom Jan 29, 2026
Merged
fix(azure): remove duplicated findings in entra_user_with_vm_access_has_mfa#9914HugoPBrito merged 3 commits intomasterfrom
HugoPBrito merged 3 commits intomasterfrom
Conversation
Contributor
|
✅ All necessary |
Contributor
|
✅ Conflict Markers Resolved All conflict markers have been successfully resolved in this pull request. |
puchy22
reviewed
Jan 29, 2026
.../azure/services/entra/entra_user_with_vm_access_has_mfa/entra_user_with_vm_access_has_mfa.py
Outdated
Show resolved
Hide resolved
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #9914 +/- ##
===========================================
+ Coverage 25.64% 85.99% +60.35%
===========================================
Files 836 222 -614
Lines 23761 5692 -18069
===========================================
- Hits 6093 4895 -1198
+ Misses 17668 797 -16871
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
Contributor
🔒 Container Security ScanImage: 📊 Vulnerability Summary
3 package(s) affected
|
puchy22
approved these changes
Jan 29, 2026
Collaborator
💚 All backports created successfully
Questions ?Please refer to the Backport tool documentation and see the Github Action logs for details |
Hamza-abughazaleh
pushed a commit
to Raed-sh/prowler
that referenced
this pull request
Feb 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
The check
entra_user_with_vm_access_has_mfawas reporting duplicated findings when a user had multiple roles that grant VM access (e.g., Owner + Virtual Machine Contributor) within the same subscription.Fix: #9913
Description
This PR fixes the duplication by tracking which user+subscription combinations have already been reported. Once a finding is generated for a user in a subscription, subsequent role assignments for the same combination are skipped.
Changes:
reported_combinationsset to track(user.id, subscription_name)pairsSteps to review
entra_user_with_vm_access_has_mfa.pyChecklist
Community Checklist
SDK/CLI
License
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.