feat(m365): add exchange_shared_mailbox_sign_in_disabled check#9828
Merged
HugoPBrito merged 5 commits intomasterfrom Jan 26, 2026
Merged
feat(m365): add exchange_shared_mailbox_sign_in_disabled check#9828HugoPBrito merged 5 commits intomasterfrom
HugoPBrito merged 5 commits intomasterfrom
Conversation
Add new check to verify that shared mailboxes have sign-in blocked in Entra ID. Shared mailboxes should only be accessed through delegation to maintain accountability and reduce attack surface. Based on CIS Microsoft 365 Foundations Benchmark v5.0.0 - Requirement 1.2.2 Changes: - Add get_shared_mailboxes() to M365PowerShell class - Add SharedMailbox model to exchange_service.py - Add _get_shared_mailboxes() method to Exchange service - Implement exchange_shared_mailbox_sign_in_disabled check
Contributor
|
✅ Conflict Markers Resolved All conflict markers have been successfully resolved in this pull request. |
Contributor
|
✅ All necessary |
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #9828 +/- ##
==========================================
- Coverage 92.07% 88.69% -3.39%
==========================================
Files 181 94 -87
Lines 25074 3564 -21510
==========================================
- Hits 23087 3161 -19926
+ Misses 1987 403 -1584
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
Contributor
🔒 Container Security ScanImage: 📊 Vulnerability Summary
3 package(s) affected
|
- Fix security issue: handle None case when Entra user not found - Update CLI remediation to use modern Update-MgUser cmdlet - Add comprehensive tests for the check (PASS, FAIL, empty, None) - Add service test for _get_shared_mailboxes() - Add additional documentation URL for CIS benchmark
HugoPBrito
reviewed
Jan 22, 2026
Member
HugoPBrito
left a comment
There was a problem hiding this comment.
Please, also update the changelog since 5.17 was released.
...hange_shared_mailbox_sign_in_disabled/exchange_shared_mailbox_sign_in_disabled.metadata.json
Outdated
Show resolved
Hide resolved
...hange_shared_mailbox_sign_in_disabled/exchange_shared_mailbox_sign_in_disabled.metadata.json
Outdated
Show resolved
Hide resolved
…d_mailbox_sign_in_disabled
- Update remediation steps to use Entra admin center path - Remove CIS reference from metadata Notes field - Add check to CIS 4.0 and 6.0 M365 compliance frameworks (req 1.2.2) - Move changelog entry to unreleased v5.18.0 section
cb9d7e0 to
a6946f3
Compare
HugoPBrito
approved these changes
Jan 26, 2026
Hamza-abughazaleh
pushed a commit
to Raed-sh/prowler
that referenced
this pull request
Feb 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
Add new security check for Microsoft 365 Exchange Online to verify that shared mailboxes have sign-in blocked in Entra ID.
Based on CIS Microsoft 365 Foundations Benchmark v5.0.0 - Requirement 1.2.2.
Description
This PR adds a new M365 Exchange check
exchange_shared_mailbox_sign_in_disabledthat verifies shared mailboxes cannot be used for direct sign-in. Shared mailboxes should only be accessed through delegation to maintain accountability and reduce attack surface.Changes:
get_shared_mailboxes()method toM365PowerShellclass to retrieve shared mailboxes via PowerShellSharedMailboxmodel toexchange_service.py_get_shared_mailboxes()method to Exchange serviceAccountEnabledisFalseSteps to review
get_shared_mailboxes()methodSharedMailboxmodel and service implementationChecklist
Community Checklist
SDK/CLI
Get-EXOMailboxand Entra ID permissionsLicense
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.