Skip to content

feat(ui): add search bar when adding a provider#9634

Merged
alejandrobailo merged 3 commits intomasterfrom
add-scrollbar-add-provider-page
Dec 23, 2025
Merged

feat(ui): add search bar when adding a provider#9634
alejandrobailo merged 3 commits intomasterfrom
add-scrollbar-add-provider-page

Conversation

@pedrooot
Copy link
Member

@pedrooot pedrooot commented Dec 22, 2025

Description

This pull request refactors the RadioGroupProvider component to improve scalability and user experience. The main changes include introducing a searchable provider list, dynamically rendering provider options, and streamlining the code for maintainability.

Screen.Recording.2025-12-22.at.13.19.56.mov
Screen.Recording.2025-12-22.at.13.29.01.mov

User experience improvements:

  • Added a search input field to filter providers by name or value, making it easier for users to find specific providers.
  • Included clear and search icons (SearchIcon, XCircle) for better usability in the search input. [1] [2]

Code maintainability and scalability:

  • Replaced hardcoded provider radio options with a PROVIDERS array, allowing dynamic rendering of provider choices and easier future updates. [1] [2]
  • Updated the rendering logic to display a message when no providers match the search term, improving feedback for users.

Steps to review

Please add a detailed description of how to review this PR.

Checklist

UI

  • All issue/task requirements work as expected on the UI
  • Screenshots/Video of the functionality flow (if applicable) - Mobile (X < 640px)
  • Screenshots/Video of the functionality flow (if applicable) - Table (640px > X < 1024px)
  • Screenshots/Video of the functionality flow (if applicable) - Desktop (X > 1024px)
  • Ensure new entries are added to CHANGELOG.md, if applicable.

API

  • Verify if API specs need to be regenerated.
  • Check if version updates are required (e.g., specs, Poetry, etc.).
  • Ensure new entries are added to CHANGELOG.md, if applicable.

License

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@pedrooot pedrooot requested a review from a team as a code owner December 22, 2025 12:26
@github-actions
Copy link
Contributor

github-actions bot commented Dec 22, 2025

✅ All necessary CHANGELOG.md files have been updated.

@github-actions
Copy link
Contributor

github-actions bot commented Dec 22, 2025

Conflict Markers Resolved

All conflict markers have been successfully resolved in this pull request.

@github-actions
Copy link
Contributor

github-actions bot commented Dec 22, 2025

🔒 Container Security Scan

Image: prowler-ui:38efb5b
Last scan: 2025-12-23 11:07:45 UTC

✅ No Vulnerabilities Detected

The container image passed all security checks. No known CVEs were found.

📋 Resources:

@github-actions
Copy link
Contributor

🔒 Container Security Scan

Image: prowler-ui:75eded4
Last scan: 2025-12-22 12:39:39 UTC

✅ No Vulnerabilities Detected

The container image passed all security checks. No known CVEs were found.

📋 Resources:

@alejandrobailo alejandrobailo self-assigned this Dec 23, 2025
@alejandrobailo
Copy link
Contributor

  • Added shadcn components related with this view

@alejandrobailo alejandrobailo merged commit 8ce56b5 into master Dec 23, 2025
34 of 35 checks passed
@alejandrobailo alejandrobailo deleted the add-scrollbar-add-provider-page branch December 23, 2025 11:09
Hamza-abughazaleh pushed a commit to Raed-sh/prowler that referenced this pull request Feb 11, 2026
Co-authored-by: alejandrobailo <alejandrobailo94@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants