Skip to content

fix: make scan_id mandatory in compliance overviews endpoint#9560

Merged
AdriiiPRodri merged 3 commits intomasterfrom
fix-scan_id-compliance-overview
Dec 15, 2025
Merged

fix: make scan_id mandatory in compliance overviews endpoint#9560
AdriiiPRodri merged 3 commits intomasterfrom
fix-scan_id-compliance-overview

Conversation

@AdriiiPRodri
Copy link
Contributor

@AdriiiPRodri AdriiiPRodri commented Dec 15, 2025

Context

The ComplianceOverviewFilter was allowing queries without a scan_id filter, which could return large datasets across multiple scans. This is problematic because compliance overview data should always be queried within the context of a specific scan.

Description

Makes scan_id a mandatory filter parameter in the ComplianceOverviewFilter.

Steps to review

Please add a detailed description of how to review this PR.

Checklist

UI

  • All issue/task requirements work as expected on the UI
  • Screenshots/Video of the functionality flow (if applicable) - Mobile (X < 640px)
  • Screenshots/Video of the functionality flow (if applicable) - Table (640px > X < 1024px)
  • Screenshots/Video of the functionality flow (if applicable) - Desktop (X > 1024px)
  • Ensure new entries are added to CHANGELOG.md, if applicable.

API

  • Verify if API specs need to be regenerated.
  • Check if version updates are required (e.g., specs, Poetry, etc.).
  • Ensure new entries are added to CHANGELOG.md, if applicable.

License

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@AdriiiPRodri AdriiiPRodri requested a review from a team as a code owner December 15, 2025 16:15
@github-actions
Copy link
Contributor

github-actions bot commented Dec 15, 2025

✅ All necessary CHANGELOG.md files have been updated.

@github-actions
Copy link
Contributor

github-actions bot commented Dec 15, 2025

Conflict Markers Resolved

All conflict markers have been successfully resolved in this pull request.

@vicferpoy vicferpoy changed the title fix: make scan_id mandatory fix: make scan_id mandatory in compliance overviews endpoint Dec 15, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Dec 15, 2025

🔒 Container Security Scan

Image: prowler-api:3f20370
Last scan: 2025-12-15 16:22:40 UTC

📊 Vulnerability Summary

Severity Count
🔴 Critical 4
Total 4

3 package(s) affected

⚠️ Action Required

Critical severity vulnerabilities detected. These should be addressed before merging:

  • Review the detailed scan results
  • Update affected packages to patched versions
  • Consider using a different base image if updates are unavailable

📋 Resources:

@codecov
Copy link

codecov bot commented Dec 15, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.43%. Comparing base (79ac7cf) to head (fe3c477).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #9560   +/-   ##
=======================================
  Coverage   92.43%   92.43%           
=======================================
  Files         159      159           
  Lines       22675    22675           
=======================================
  Hits        20960    20960           
  Misses       1715     1715           
Flag Coverage Δ
api 92.43% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
prowler ∅ <ø> (∅)
api 92.43% <100.00%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@AdriiiPRodri AdriiiPRodri merged commit b549c8d into master Dec 15, 2025
37 checks passed
@AdriiiPRodri AdriiiPRodri deleted the fix-scan_id-compliance-overview branch December 15, 2025 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants