Skip to content

chore(aws): enhance metadata for servicecatalog service#9410

Merged
danibarranqueroo merged 4 commits intomasterfrom
review_metadata_aws_servicecatalog
Dec 16, 2025
Merged

chore(aws): enhance metadata for servicecatalog service#9410
danibarranqueroo merged 4 commits intomasterfrom
review_metadata_aws_servicecatalog

Conversation

@puchy22
Copy link
Member

@puchy22 puchy22 commented Dec 2, 2025

Context

Updating aws servicecatalog service metadata to conform with the new standardized metadata format used across Prowler checks, defined in #8411.

Description

This PR updates all metadata files for AWS Service Catalog checks to adapt to the new metadata format. The changes ensure consistency with the metadata structure being adopted across all Prowler services. The modified checks are:

  • servicecatalog_portfolio_shared_within_organization_only

Checklist

API

  • Verify if API specs need to be regenerated.
  • Check if version updates are required (e.g., specs, Poetry, etc.).
  • Ensure new entries are added to CHANGELOG.md, if applicable.

License

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@puchy22 puchy22 requested review from a team as code owners December 2, 2025 11:05
@github-actions github-actions bot added the provider/aws Issues/PRs related with the AWS provider label Dec 2, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Dec 2, 2025

Conflict Markers Resolved

All conflict markers have been successfully resolved in this pull request.

@github-actions
Copy link
Contributor

github-actions bot commented Dec 2, 2025

✅ All necessary CHANGELOG.md files have been updated.

@github-actions
Copy link
Contributor

github-actions bot commented Dec 2, 2025

🔒 Container Security Scan

Image: prowler:3f1dbb2
Last scan: 2025-12-16 11:11:43 UTC

📊 Vulnerability Summary

Severity Count
🔴 Critical 3
Total 3

3 package(s) affected

⚠️ Action Required

Critical severity vulnerabilities detected. These should be addressed before merging:

  • Review the detailed scan results
  • Update affected packages to patched versions
  • Consider using a different base image if updates are unavailable

📋 Resources:

@codecov
Copy link

codecov bot commented Dec 2, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 2.66%. Comparing base (90e3fab) to head (ffc392f).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##           master   #9410      +/-   ##
=========================================
- Coverage    4.15%   2.66%   -1.50%     
=========================================
  Files         830     830              
  Lines       23443   23443              
=========================================
- Hits          974     624     -350     
- Misses      22469   22819     +350     
Flag Coverage Δ
prowler-py3.10-aws 2.66% <ø> (?)
prowler-py3.11-aws 2.66% <ø> (?)
prowler-py3.12-aws 2.66% <ø> (-1.50%) ⬇️
prowler-py3.9-aws 2.66% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
prowler 2.66% <ø> (-1.50%) ⬇️
api ∅ <ø> (∅)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@danibarranqueroo danibarranqueroo merged commit 1b2c73d into master Dec 16, 2025
35 of 36 checks passed
@danibarranqueroo danibarranqueroo deleted the review_metadata_aws_servicecatalog branch December 16, 2025 11:12
Hamza-abughazaleh pushed a commit to Raed-sh/prowler that referenced this pull request Feb 11, 2026
…oud#9410)

Co-authored-by: Daniel Barranquero <danielbo2001@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

metadata-review provider/aws Issues/PRs related with the AWS provider

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants