Add application note for explicit presence tracking. #7390
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This includes instructions for enabling explicit presence tracking in proto3, and also explains implicit presence. The language examples were written by inspection, and not individually tested.
haberman
requested changes
Apr 20, 2020
Member
haberman
left a comment
haberman
left a comment
There was a problem hiding this comment.
I haven't been able to get through all of this yet, but a few preliminary comments.
haberman
requested changes
Apr 23, 2020
Member
haberman
left a comment
haberman
left a comment
There was a problem hiding this comment.
Thanks for the update! I went through the rest of the doc and found a few more things.
- noted experimental status in release 3.12 - clarified JSON null and ordering concerns - "implicit presence" -> "no presence" - clarified message presence in proto3 - fixed round-trip example (client definitions were switched)
haberman
approved these changes
Apr 23, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Singular, non-message typed fields in proto3 experimentally support explicit presence tracking (see docs/field_presence.md for details).