Block subclassing #7124
Merged
Block subclassing #7124
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add GPB_FINAL macro to block subclassing of generated ObjC classes.
thomasvl
reviewed
Jan 23, 2020
Contributor
thomasvl
left a comment
thomasvl
left a comment
There was a problem hiding this comment.
commit needs up updated description since we will need to tag this for inclusion in release notes.
Contributor
Author
|
Coment added. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add GPB_FINAL macro to block subclassing of generated ObjC classes.
This will prevent subclassing of any of the protobuf classes generated by the compiler.
If you need to be able to do this, please let us know. You can temporarily "reenable" it by
redefining the GPB_FINAL macro.