Breaking Change: The base class for generated messages will be #15362
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
copybara-service
bot
force-pushed
the
test_586335533
branch
9 times, most recently
from
168f8c6 to
10b84e0
Compare
copybara-service
bot
force-pushed
the
test_586335533
branch
from
10b84e0 to
5df0387
Compare
copybara-service bot
pushed a commit
that referenced
this pull request
Mar 16, 2024
## Summary Fixes and closes #16170 by adding missing test-gen mappings and exclusions. Recent [changes](#15362) to Protocol Buffers, along with the addition of the _Editions_ feature, have evolved ahead of Maven; running the build on `main` shows build errors related to the testsuite. ## Changelog - fix: missing test-gen mappings - fix: missing test exclusions Closes #16176 COPYBARA_INTEGRATE_REVIEW=#16176 from sgammon:fix/issue-16170 2be118c PiperOrigin-RevId: 616310039
deannagarcia
pushed a commit
to deannagarcia/protobuf
that referenced
this pull request
Jun 20, 2024
## Summary Fixes and closes protocolbuffers#16170 by adding missing test-gen mappings and exclusions. Recent [changes](protocolbuffers#15362) to Protocol Buffers, along with the addition of the _Editions_ feature, have evolved ahead of Maven; running the build on `main` shows build errors related to the testsuite. ## Changelog - fix: missing test-gen mappings - fix: missing test exclusions Closes protocolbuffers#16176 COPYBARA_INTEGRATE_REVIEW=protocolbuffers#16176 from sgammon:fix/issue-16170 2be118c PiperOrigin-RevId: 616310039
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Breaking Change: The base class for generated messages will be
GeneratedMessage, not GeneratedMessageV3.
To fix source compatibility make these replacements:
GeneratedMessageV3 --> GeneratedMessage
SingleFieldBuilderV3 --> SingleFieldBuilder
RepeatedFieldBuilderV3 --> RepeatedFieldBuilder