Remove ODR violation from WKT codegen#12406
Closed
mkruskal-google wants to merge 5 commits intoprotocolbuffers:mainfrom
Closed
Remove ODR violation from WKT codegen#12406mkruskal-google wants to merge 5 commits intoprotocolbuffers:mainfrom
mkruskal-google wants to merge 5 commits intoprotocolbuffers:mainfrom
Conversation
mkruskal-google
added
the
🅰️ safe for tests
github-actions
bot
removed
the
🅰️ safe for tests
mkruskal-google
added
the
🅰️ safe for tests
github-actions
bot
removed
the
🅰️ safe for tests
mkruskal-google
added
the
🅰️ safe for tests
github-actions
bot
removed
the
🅰️ safe for tests
haberman
approved these changes
Apr 5, 2023
mkruskal-google
added
the
🅰️ safe for tests
github-actions
bot
removed
the
🅰️ safe for tests
mkruskal-google
added
the
🅰️ safe for tests
github-actions
bot
removed
the
🅰️ safe for tests
mkruskal-google
added
the
🅰️ safe for tests
github-actions
bot
removed
the
🅰️ safe for tests
mkruskal-google
added
the
🅰️ safe for tests
github-actions
bot
removed
the
🅰️ safe for tests
haberman
approved these changes
Apr 5, 2023
Contributor
haberman
pushed a commit
to haberman/protobuf
that referenced
this pull request
Apr 6, 2023
Closes protocolbuffers#12406 COPYBARA_INTEGRATE_REVIEW=protocolbuffers#12406 from mkruskal-google:wkt 1c6748e PiperOrigin-RevId: 522418175
haberman
added a commit
that referenced
this pull request
Apr 6, 2023
* Remove ODR violation from WKT codegen (#12406) Closes #12406 COPYBARA_INTEGRATE_REVIEW=#12406 from mkruskal-google:wkt 1c6748e PiperOrigin-RevId: 522418175 * Removed legacy target. --------- Co-authored-by: Mike Kruskal <[email protected]>
bithium
pushed a commit
to bithium/protobuf
that referenced
this pull request
Sep 4, 2023
Closes protocolbuffers#12406 COPYBARA_INTEGRATE_REVIEW=protocolbuffers#12406 from mkruskal-google:wkt 1c6748e PiperOrigin-RevId: 522418175
bithium
pushed a commit
to bithium/protobuf
that referenced
this pull request
Sep 4, 2023
…olbuffers#12419) * Remove ODR violation from WKT codegen (protocolbuffers#12406) Closes protocolbuffers#12406 COPYBARA_INTEGRATE_REVIEW=protocolbuffers#12406 from mkruskal-google:wkt 1c6748e PiperOrigin-RevId: 522418175 * Removed legacy target. --------- Co-authored-by: Mike Kruskal <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.