PHP Extension - Missing Google\Protobuf\Value:has* Methods

[FabioBatSilva]

The PHP C extension implementation is missing has* methods for the Google\Protobuf\Value class that are present in the native PHP implementation.

This creates inconsistency between the two:

PHP Implementation :

• hasNullValue
• hasNumberValue
• hasStringValue
• hasBoolValue
• hasStructValue
• hasListValue

C Implementation

protobuf/php/ext/google/protobuf/wkt.inc

Lines 1356 to 1371 in b51d59e

	static zend_function_entry google_protobuf_Value_phpmethods[] = {
	PHP_ME(google_protobuf_Value, __construct, arginfo_construct, ZEND_ACC_PUBLIC)
	PHP_ME(google_protobuf_Value, getNullValue, arginfo_void, ZEND_ACC_PUBLIC)
	PHP_ME(google_protobuf_Value, setNullValue, arginfo_setter, ZEND_ACC_PUBLIC)
	PHP_ME(google_protobuf_Value, getNumberValue, arginfo_void, ZEND_ACC_PUBLIC)
	PHP_ME(google_protobuf_Value, setNumberValue, arginfo_setter, ZEND_ACC_PUBLIC)
	PHP_ME(google_protobuf_Value, getStringValue, arginfo_void, ZEND_ACC_PUBLIC)
	PHP_ME(google_protobuf_Value, setStringValue, arginfo_setter, ZEND_ACC_PUBLIC)
	PHP_ME(google_protobuf_Value, getBoolValue, arginfo_void, ZEND_ACC_PUBLIC)
	PHP_ME(google_protobuf_Value, setBoolValue, arginfo_setter, ZEND_ACC_PUBLIC)
	PHP_ME(google_protobuf_Value, getStructValue, arginfo_void, ZEND_ACC_PUBLIC)
	PHP_ME(google_protobuf_Value, setStructValue, arginfo_setter, ZEND_ACC_PUBLIC)
	PHP_ME(google_protobuf_Value, getListValue, arginfo_void, ZEND_ACC_PUBLIC)
	PHP_ME(google_protobuf_Value, setListValue, arginfo_setter, ZEND_ACC_PUBLIC)
	PHP_ME(google_protobuf_Value, getKind, arginfo_void, ZEND_ACC_PUBLIC)
	ZEND_FE_END

---

What version of protobuf and what language are you using?
Version: main
Language: php
OS: Linux

What did you do?

<?php

require_once (dirname(__DIR__) . '/vendor/autoload.php');

use Google\Protobuf\Value;

$v = new Value();

var_dump($v->hasNullValue());

# Compile the extension 
./php/tests/compile_extension.sh

# Run script
php -d display_errors=on -dextension=../ext/google/protobuf/modules/protobuf.so has_value_test.php

What did you expect to see

bool(false)

What did you see instead?

Uncaught Error: Call to undefined method Google\Protobuf\Value::hasNullValue() 

[JasonLunn]

Thanks for reporting this issue, @FabioBatSilva.

Is this issue unique to the Value class, or does it impact other well known types?

[FabioBatSilva]

Yes, I think there are more..

PHP:
https://github.com/search?q=repo%3Aprotocolbuffers%2Fprotobuf+language%3Aphp+path%3Aphp%2Fsrc%2FGoogle%2FProtobuf+%2Fpublic+function.*has%2F&type=code

EXT:
https://github.com/search?q=repo%3Aprotocolbuffers%2Fprotobuf++path%3Aphp%2Fext+%2FPHP_ME%5C%28.*%2C*has%5Cw%2B.*%5C%29%2F&type=code