proto_descriptor_set Bazel rule missing

[SanjayVas]

rules_proto is deprecated and points here for Bazel rules, but this module is missing the proto_descriptor_set rule that was defined there.

[zhangskz]

Assuming this is referring to rules_proto/proto/defs.bzl proto_descriptor_set: https://github.com/bazelbuild/rules_proto/blame/44d3d92175471ae6f1e8b996d85dc22fc4698a6d/proto/defs.bzl#L26

@comius Do you know if this should've also been moved, or if this was intentionally excluded?

[github-actions]

We triage inactive PRs and issues in order to make it easier to find active work. If this issue should remain active or becomes active again, please add a comment.

This issue is labeled inactive because the last activity was over 90 days ago. This issue will be closed and archived after 14 additional days without activity.

[comius]

I intentionally excluded proto_descriptor_set, there was a lack of evidence that it's a commonly used rule on github. https://github.com/search?q=v3_proto_set+%28path%3A*.bzl+OR+path%3A**%2FBUILD+OR+path%3A**%2FBUILD.bazel%29&type=code&ref=advsearch

[SanjayVas]

I intentionally excluded proto_descriptor_set, there was a lack of evidence that it's a commonly used rule on github. https://github.com/search?q=v3_proto_set+%28path%3A*.bzl+OR+path%3A**%2FBUILD+OR+path%3A**%2FBUILD.bazel%29&type=code&ref=advsearch

Is there a reason your search is for v3_proto_set rather than proto_descriptor_set?

[comius]

I pasted the wrong query: https://github.com/search?q=proto_descriptor_set+%28path%3A*.bzl+OR+path%3A**%2FBUILD+OR+path%3A**%2FBUILD.bazel%29&type=code&ref=advsearch

The only use was in envoy, and the only target was v3_proto_set.

[SanjayVas]

I did the same search but with forks excluded to reduce noise. Manually excluding the false positives where the rule isn't loaded from rules_proto and trying to group by org, I see the following repos:

• https://github.com/envoyproxy/envoy
• https://github.com/envoyproxy/envoy-openssl
• https://github.com/google/cel-java
• https://github.com/google/skia-buildbot
• https://github.com/grpc-ecosystem/proto_processing_lib
• https://github.com/privacysandbox/bidding-auction-servers
• https://github.com/privacysandbox/protected-auction-key-value-service
• https://github.com/privacysandbox/data-plane-shared-libraries
• https://github.com/abitofhelp/apis-rust
• https://github.com/abitofhelp/bazel7_go_grpc
• https://github.com/abitofhelp/bazel_grpc_pbuf_go
• https://github.com/world-federation-of-advertisers/cross-media-measurement
• https://github.com/world-federation-of-advertisers/local-market-configuration
• https://github.com/world-federation-of-advertisers/common-jvm
• https://github.com/stackb/rules_proto
• https://github.com/EngFlow/engflowapis
• https://github.com/rendezqueue/rules_sxproto
• https://github.com/bulwark-security/bulwark

[wyrickre]

We also use this. Please revive it.

[turmanticant]

Also wanted to chime in that I am using this as well. I just bumped into this trying to migrate from rules_proto.

[SpencerC]

+1