feat: add the build tag to the member (serf_lan/wan) labels#228
Open
ylmrx wants to merge 2 commits intoprometheus:masterfrom
Open
feat: add the build tag to the member (serf_lan/wan) labels#228ylmrx wants to merge 2 commits intoprometheus:masterfrom
ylmrx wants to merge 2 commits intoprometheus:masterfrom
Conversation
ylmrx
force-pushed
the
feat/add_build_label_to_members
branch
from
c92c31c to
08354df
Compare
Signed-off-by: ylamouroux <[email protected]>
Signed-off-by: ylamouroux <[email protected]>
ylmrx
force-pushed
the
feat/add_build_label_to_members
branch
from
ba7bc36 to
413d3b8
Compare
Author
|
@simonpasquier Hello Simon, we'd like to propose this tiny bit of code, I'm failing to reach for the variable (ie. consul version) from the test.go code though, as I'm super not used to this CI :) |
Member
|
This should be a separate info metric, not attached to the status metric. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We need those here, they could prove useful to everyone ! :)
Take care <3