Skip to content

changed the name of all variables with min/max name - #1606

Merged
ArthurSens merged 3 commits into
prometheus:mainfrom
parthlaw:min_max_variable_rename
Sep 2, 2024
Merged

changed the name of all variables with min/max name#1606
ArthurSens merged 3 commits into
prometheus:mainfrom
parthlaw:min_max_variable_rename

Conversation

@parthlaw

@parthlaw parthlaw commented Aug 31, 2024 •
edited
Loading

Copy link
Copy Markdown
Contributor

Parth Lawania @parthlaw
changed the name of all variables with min/max name
a711084 
Signed-off-by: Parth Lawania <parthlawania@gmail.com>
@SuperQ
SuperQ requested a review from ArthurSens August 31, 2024 10:58
SuperQ
SuperQ approved these changes Aug 31, 2024
View reviewed changes

@SuperQ SuperQ left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@ArthurSens

ArthurSens commented Aug 31, 2024

Copy link
Copy Markdown
Member

Thanks! Could you also remove these lines and make sure our linter is happy with your changes?

client_golang/.golangci.yml

Lines 69 to 70 in ffc4cc6

predeclared:
ignore: "min,max"

@parthlaw

parthlaw commented Sep 1, 2024

Copy link
Copy Markdown
Contributor Author

Thanks! Could you also remove these lines and make sure our linter is happy with your changes?

client_golang/.golangci.yml

Lines 69 to 70 in ffc4cc6

predeclared:
ignore: "min,max"

Removed the conditions. Please review the PR again.

SuperQ
SuperQ approved these changes Sep 1, 2024
View reviewed changes

@SuperQ SuperQ left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work.

@ArthurSens
ArthurSens merged commit 850b6c0 into prometheus:main Sep 2, 2024
This was referenced Feb 19, 2025
Merged
Merged
@dghubble-renovate dghubble-renovate Bot mentioned this pull request Feb 19, 2025
Merged
1 task
@mr-borboto mr-borboto Bot mentioned this pull request Feb 19, 2025
Merged
1 task
@pull-bunyan pull-bunyan Bot mentioned this pull request Feb 19, 2025
Closed
1 task
This was referenced Feb 19, 2025
Closed
Closed
@theriver-bot theriver-bot Bot mentioned this pull request Feb 19, 2025
Merged
1 task
@larsl-renovate larsl-renovate Bot mentioned this pull request Feb 19, 2025
Merged
1 task
@cilium-renovate cilium-renovate Bot mentioned this pull request Feb 17, 2025
Merged
1 task
This was referenced Feb 19, 2025
Merged
Merged
Merged
Merged
@rwunderer rwunderer mentioned this pull request Feb 19, 2025
Merged
1 task
This was referenced Feb 19, 2025
Open
Closed
Closed
Closed
Closed
Closed
This was referenced Jul 8, 2026
Open
Closed
Merged
This was referenced Jul 9, 2026
Merged
Merged
@renovate-bot renovate-bot mentioned this pull request Jul 10, 2026
Open
1 task
@renovate renovate Bot mentioned this pull request Jul 11, 2026
Closed
1 task
@meza-deps meza-deps Bot mentioned this pull request Jul 11, 2026
Closed
1 task
This was referenced Jul 13, 2026
Closed
Closed
Merged
Closed
Open
Closed
Open
Closed
Closed
Closed
Open
Open
Closed
Closed
Open
Open
Closed
Open
This was referenced Jul 21, 2026
Open
Open
Open
@renovate renovate Bot mentioned this pull request Jul 27, 2026
Open
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@SuperQ SuperQ SuperQ approved these changes
@ArthurSens ArthurSens Awaiting requested review from ArthurSens

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@parthlaw @ArthurSens @SuperQ