Skip to content

Clarify exemplar(Add|Observe) by renaming to (add|observe)WithExemplar#1122

Merged
kakkoyun merged 3 commits into
prometheus:mainfrom
hairyhenderson:rename-exemplarAdd-1120
Aug 22, 2022
Merged

Clarify exemplar(Add|Observe) by renaming to (add|observe)WithExemplar#1122
kakkoyun merged 3 commits into
prometheus:mainfrom
hairyhenderson:rename-exemplarAdd-1120

Conversation

@hairyhenderson

Copy link
Copy Markdown
Contributor

Fixes #1120

Signed-off-by: Dave Henderson dhenderson@gmail.com

Signed-off-by: Dave Henderson <dhenderson@gmail.com>
Comment thread prometheus/promhttp/instrument_server.go
Signed-off-by: Dave Henderson <dhenderson@gmail.com>
@hairyhenderson

Copy link
Copy Markdown
Contributor Author

I've also noticed exemplarObserve, and I've taken the liberty of renaming that one too.

Signed-off-by: Dave Henderson <dhenderson@gmail.com>
@hairyhenderson hairyhenderson changed the title Clarify exemplarAdd by renaming to addWithExemplar Clarify exemplar(Add|Observe) by renaming to (add|observe)WithExemplar Aug 22, 2022

@kakkoyun kakkoyun left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks a lot.

@kakkoyun kakkoyun enabled auto-merge (squash) August 22, 2022 15:25
@kakkoyun kakkoyun merged commit 4c41dfb into prometheus:main Aug 22, 2022
@hairyhenderson hairyhenderson deleted the rename-exemplarAdd-1120 branch August 22, 2022 16:06
@hairyhenderson

Copy link
Copy Markdown
Contributor Author

@kakkoyun I wonder if you (or someone) can cut a 1.13.1 soon with this fix in it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

promhttp: Rename exemplarAdd

2 participants