This repository was archived by the owner on Aug 13, 2019. It is now read-only.
Add WAL Size to Retention Size check #650
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
July 3, 2019 10:38
…ze limit Summary: Add method to compute size of WAL, and use it to respect retention size limit Test Plan: * Create dummy endpoint with tons of metrics * Setup prom with low retention limits to see the effects quicker * Have prom collect the dummy endpoints metrics * Watch the WAL expand and do its thing Reviewers: tl Differential Revision: https://phabricator.hudson-trading.com/D103543
…ze limit Signed-off-by: Dipack P Panjabi <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Compute the size of the WAL and use it while calculating if exceeding the max retention size limit.