Gitlab Collector: Oldest Blocked collector and test #838
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Felix Yuan <[email protected]>
SuperQ
requested changes
Jun 30, 2023
Contributor
SuperQ
left a comment
SuperQ
left a comment
There was a problem hiding this comment.
I think we should refactor these separate collectors into a single pg_stat_activity collector to reduce the number of queries to this table.
|
|
||
| oldestBlockedQuery = ` | ||
| SELECT | ||
| coalesce(extract('epoch' from max(clock_timestamp() - state_change)), 0) age_seconds |
Contributor
There was a problem hiding this comment.
Similar to others, we should extract the raw timestamp for this metric.
Contributor
Author
There was a problem hiding this comment.
I don't know if that makes sense since we're trying to measure the max duration that a query's been blocked here
Contributor
There was a problem hiding this comment.
This can still be done with time() - metric.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Split from #819