Skip to content

Fix null deref issue in apply command #324

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
John-Leitch wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix null deref issue in apply command #324

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion src/Aspirate.Services/Implementations/KustomizeService.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,10 @@ public async Task WriteSecretsOutToTempFiles(AspirateState state, List<string> f

foreach (var resourceSecrets in secretProvider.State.Secrets.Where(x => x.Value.Keys.Count > 0))
{
var resourcePath = fileSystem.Path.Combine(state.OutputPath, resourceSecrets.Key);
var manifestPath = (state.OutputPath ?? state.InputPath) ??
throw new InvalidOperationException("Could not write secret, manifest path not set.");

var resourcePath = fileSystem.Path.Combine(manifestPath, resourceSecrets.Key);

if (!fileSystem.Directory.Exists(resourcePath))
{
Expand Down