Skip to content

Comments

Add support for passing secrets as docker build args#232

Open
Greven145 wants to merge 1 commit intoprom3theu5:mainfrom
Greven145:feature/addUserSecretsToBuildCommand
Open

Add support for passing secrets as docker build args#232
Greven145 wants to merge 1 commit intoprom3theu5:mainfrom
Greven145:feature/addUserSecretsToBuildCommand

Conversation

@Greven145
Copy link

🧯 Bugfix Description

This PR introduces the ability to enable user secrets during build command execution and the substitution of build arguments from inputs and secrets. This closes #230.

🧰 Technical Solution

  • Create a new cli flag --use-secrets and add it to the build command
  • Unlock secrets if --use-secrets is specified, regardless of the command's default
  • Include the --secret-password option for the build command (for non-interactive builds)
  • Add logic to substitute parameter values in docker build args
  • Add tests for docker build arg substitution

@prom3theu5
Copy link
Owner

Thanks for this - I'll check over it tonight :)

@Greven145
Copy link
Author

Hey! Any update on this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Inputs are not resolved for docker build args

3 participants