Fix rendering of mimir-distributed 4.3.0 Helm chart for OpenShift with Helm 3.17.1#27
Merged
Fix rendering of mimir-distributed 4.3.0 Helm chart for OpenShift with Helm 3.17.1#27
Conversation
simu
force-pushed
the
fix/rbac-scc-helm-3.17.1
branch
from
e3068f5 to
8a3ff27
Compare
simu
commented
Feb 25, 2025
…h Helm 3.17.1 Helm 3.17.1 has fixed a long-standing bug which affects how sub-chart values are merged in helm/helm#13654. The Commodore 1.27.3 image uses Helm 3.17.1. Somehow, the fix breaks the suggested configuration for the mimir-distributed chart when setting `rbac.type=scc`, since the `null` value overrides for the sub-chart fields are now explicitly visible as fields with value `null`. This breaks the validation logic which checks the presence of the fields We adjust the validation by copying a fixed `validate.yaml` into the downloaded helm chart. However, this now injects `null` values in the rendered manifest, so we also add a postprocessing filter to delete those nulls.
Rendered from template version: main (98d16f9)
simu
force-pushed
the
fix/rbac-scc-helm-3.17.1
branch
from
80195dc to
42769b7
Compare
|
🚀 This PR has been released as Triggering workflows 🛠️ Auto tagging enabled with label |
DebakelOrakel
approved these changes
Jan 20, 2026
bastjan
approved these changes
Jan 20, 2026
NOTE: This requires Commodore v1.31.0 or newer
simu
force-pushed
the
fix/rbac-scc-helm-3.17.1
branch
from
beaba01 to
404af5b
Compare
bastjan
approved these changes
Jan 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Helm 3.17.1 has fixed a long-standing bug which affects how sub-chart values are merged in helm/helm#13654. The Commodore 1.27.3 image uses Helm 3.17.1.
Somehow, the fix breaks the suggested configuration for the mimir-distributed chart when setting
rbac.type=scc, since thenullvalue overrides for the sub-chart fields are now explicitly visible as fields with valuenull.This breaks the validation logic which checks the presence of the fields We adjust the validation by copying a fixed
validate.yamlinto the downloaded helm chart. However, this now injectsnullvalues in the rendered manifest, so we also add a postprocessing filter to delete those nulls.Checklist
changelog.
The PR has a meaningful description that sums up the change. It will be
linked in the changelog.
bug,enhancement,documentation,change,breaking,dependencyas they show up in the changelog.