Add @Singular support for Optional types #3977
Open
+832
−0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds support for using
@SingularwithOptionaltypes in@Builder.Changes
JavacJavaUtilOptionalSingularizerfor javac compiler supportEclipseJavaUtilOptionalSingularizerfor Eclipse compiler supportBehavior
For a field annotated with
@Singular Optional<T>, the builder generates:TOptional.ofNullable()or returnsOptional.empty()Example
Test Plan
test/transform/resource/ant testFixes #3976