Skip to content

Conversation

@Devang-Solanki
Copy link
Contributor

@ehsandeep ehsandeep changed the base branch from main to dev May 6, 2023 11:49
@ehsandeep ehsandeep linked an issue May 30, 2023 that may be closed by this pull request
Copy link
Member

@ehsandeep ehsandeep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Devang-Solanki see the lint erros.

@Devang-Solanki
Copy link
Contributor Author

Hey @ehsandeep I tried solving the errors can you please check it?

Copy link
Member

@dogancanbakir dogancanbakir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Devang-Solanki Thanks, great job! I just left a couple of comments for you.

@Devang-Solanki
Copy link
Contributor Author

@dogancanbakir I've improved the code as per your suggestion please check it.

Copy link
Member

@dogancanbakir dogancanbakir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@tarunKoyalwar tarunKoyalwar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Devang-Solanki thanks for PR and adding new source to subfinder. i have made minor changes to reuse existing logic related to http session .

$  ./subfinder -d hackerone.com -s netlas -v

               __    _____           __         
   _______  __/ /_  / __(_)___  ____/ /__  _____
  / ___/ / / / __ \/ /_/ / __ \/ __  / _ \/ ___/
 (__  ) /_/ / /_/ / __/ / / / / /_/ /  __/ /    
/____/\__,_/_.___/_/ /_/_/ /_/\__,_/\___/_/

		projectdiscovery.io

[INF] Current subfinder version v2.5.8 (outdated)
[INF] Loading provider config from /Users/tarun/.config/subfinder/provider-config.yaml
[DBG] API key(s) found for binaryedge.
[DBG] API key(s) found for bufferover.
[DBG] API key(s) found for censys.
[DBG] API key(s) found for github.
[DBG] API key(s) found for netlas.
[DBG] API key(s) found for passivetotal.
[DBG] API key(s) found for securitytrails.
[DBG] API key(s) found for shodan.
[DBG] API key(s) found for virustotal.
[DBG] API key(s) found for whoisxmlapi.
[DBG] Selected source(s) for this search: netlas
[INF] Enumerating subdomains for hackerone.com
[netlas] go.hackerone.com
[netlas] mta-sts.managed.hackerone.com
[netlas] info.hackerone.com
[netlas] mta-sts.forwarding.hackerone.com
[netlas] forwarding.hackerone.com
[netlas] api.hackerone.com
[netlas] links.hackerone.com
[netlas] mta-sts.hackerone.com
[netlas] events.hackerone.com
[netlas] support.hackerone.com
[netlas] hackerone-bugbounty.hackerone.com
[netlas] gslink.hackerone.com
[netlas] docs.hackerone.com
[netlas] www.hackerone.com
[netlas] a.ns.hackerone.com
[netlas] b.ns.hackerone.com
docs.hackerone.com
www.hackerone.com
a.ns.hackerone.com
mta-sts.hackerone.com
events.hackerone.com
go.hackerone.com
mta-sts.managed.hackerone.com
api.hackerone.com
links.hackerone.com
mta-sts.forwarding.hackerone.com
gslink.hackerone.com
b.ns.hackerone.com
info.hackerone.com
forwarding.hackerone.com
support.hackerone.com
hackerone-bugbounty.hackerone.com
[INF] Found 16 subdomains for hackerone.com in 2 seconds 392 milliseconds

@ehsandeep ehsandeep merged commit f034407 into projectdiscovery:dev Jun 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add netlas as new source

4 participants