API key randomization is not working

[swdbo]

Hello !

It seems like even if multiple keys are set for a provider in provider-config.yaml, the same unique key will always be used.

// We use random selection of api keys from the list of keys supplied.
I may not fully understand the logic behind the use of rand.Intn() in the GetKeys() function.
I thought it was a way to randomly distribute calls on each run of subfinder, isn't it ?

If so, I have tested the rand package locally and on that page
You can see on the link that answers[rand.Intn(len(answers))] returns the same value everytime.

It looks like it could be simply resolved by using rand.Seed(time.Now().UnixNano()) before calling rand

Subfinder version
v2.5.1

[ehsandeep]

@swdbo thanks for reporting this, it is now fixed in the dev version of the project with #550

[swdbo]

Well done !