fix: correct matcher-status regression for multiple failed requests

cmd/integration-test/matcher-status.go

@@ -2,7 +2,10 @@ package main
 
 import (
 	"fmt"
+	"net/http"
+	"net/http/httptest"
 	"strings"
+	"sync/atomic"
 
 	"github.com/projectdiscovery/nuclei/v3/pkg/output"
 	"github.com/projectdiscovery/nuclei/v3/pkg/testutils"
@@ -16,6 +19,7 @@ var matcherStatusTestcases = []TestCaseInfo{
 	{Path: "protocols/javascript/net-https.yaml", TestCase: &javascriptNoAccess{}},
 	{Path: "protocols/websocket/basic.yaml", TestCase: &websocketNoAccess{}},
 	{Path: "protocols/dns/a.yaml", TestCase: &dnsNoAccess{}},
+	{Path: "protocols/http/matcher-status-multiple-failures.yaml", TestCase: &httpMultipleFailures{}},
 }
 
 type httpNoAccess struct{}
@@ -118,3 +122,28 @@ func (h *dnsNoAccess) Execute(filePath string) error {
 	}
 	return nil
 }
+
+type httpMultipleFailures struct{}
+
+// Execute tests that multiple failed requests all generate events with -ms flag
+func (h *httpMultipleFailures) Execute(filePath string) error {
+	var requestCount int64
+
+	ts := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
+		atomic.AddInt64(&requestCount, 1)
+		fmt.Fprintln(w, "test response")
+	}))
+	defer ts.Close()
+
+	results, err := testutils.RunNucleiTemplateAndGetResults(filePath, ts.URL, debug, "-ms", "-j")
+	if err != nil {
+		return err
+	}
+
+	actualRequestCount := atomic.LoadInt64(&requestCount)
+	if len(results) != int(actualRequestCount) {
+		return fmt.Errorf("matcher-status regression: server received %d requests but only %d events were output", actualRequestCount, len(results))
+	}
+
+	return nil
+}

integration_tests/protocols/http/matcher-status-multiple-failures.yaml

@@ -0,0 +1,19 @@
+id: matcher-status-multiple-failures
+
+info:
+  name: Test Matcher Status Multiple Failures
+  author: pdteam
+  severity: info
+
+http:
+  - method: GET
+    path:
+      - "{{BaseURL}}/"
+      - "{{BaseURL}}/test"
+      - "{{BaseURL}}/admin"
+
+    matchers:
+      - type: word
+        words:
+          - "THIS_STRING_WILL_NEVER_MATCH"
+        part: body

pkg/tmplexec/exec.go

@@ -182,8 +182,10 @@ func (e *TemplateExecuter) Execute(ctx *scan.ScanContext) (bool, error) {
 			// non-`global-matchers` templates can enter the `writeFailureCallback`
 			// func to log failure output.
 			wr := writer.WriteResult(event, e.options.Output, e.options.Progress, e.options.IssuesClient)
-			if wr && !isGlobalMatchers {
-				matched.Store(true)
+			if wr {
+				if !isGlobalMatchers {
+					matched.Store(true)
+				}
 			} else {
 				lastMatcherEvent = event
 			}