-
Notifications
You must be signed in to change notification settings - Fork 2.9k
add setDialer function to TCP protocol #6101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
- add ability to override setDialer function for tcp - socks proxy is not used incase of tcp protocol - TCP uses global tcp dialer shared, we need template request level ability to set dialer
|
Caution Review failedThe pull request is closed. WalkthroughThe change introduces a new public method Changes
Sequence Diagram(s)sequenceDiagram
participant Client
participant Request
participant Dialer as fastdialer.Dialer
Client->>Request: Call SetDialer(dialer)
Note right of Request: Assign dialer to Request.dialer field
Suggested reviewers
Poem
Tip ⚡🧪 Multi-step agentic review comment chat (experimental)
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
✨ Finishing Touches
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
Proposed changes
Checklist
Summary by CodeRabbit