fix(http): prevent addCNameIfAvailable from using closed Dialer
#5665
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added a check in `addCNameIfAvailable` to ensure the `Dialer` isnot NIL before attempting to fetch DNS data. this prevents potential panics (ex. SIGSEGV) when the `Dialer` is closed due to an interruption. Signed-off-by: Dwi Siswanto <[email protected]>
ehsandeep
approved these changes
Sep 25, 2024
ehsandeep
deleted the
dwisiswant0/fix/NIL-pointer-deref-in-http-Request-addCNameIfAvailable
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
added a check in
addCNameIfAvailableto ensurethe
Dialerisnot NIL before attempting to fetchDNS data.
this prevents potential panics (ex. SIGSEGV) when
the
Dialeris closed due to an interruption.Close #5664
Checklist