Skip to content

feat: clone event in clustering to generate correct failure events #5653

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 24, 2024
Merged

feat: clone event in clustering to generate correct failure events #5653

merged 1 commit into from
Sep 24, 2024

Conversation

@Ice3man543
Copy link
Member

@Ice3man543 Ice3man543 commented Sep 20, 2024

Proposed changes

  • Missing failure events for clustered templates in some cases

Checklist

  • Pull request is created against the dev branch
  • All checks passed (lint, unit/integration/regression tests etc.) with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

@auto-assign auto-assign bot requested a review from dogancanbakir September 20, 2024 17:05
@ehsandeep ehsandeep merged commit 6a561c6 into dev Sep 24, 2024
3 checks passed
@ehsandeep ehsandeep deleted the missing-events-scan branch September 24, 2024 13:13
@BrewTestBot BrewTestBot mentioned this pull request Sep 26, 2024
Merged
@blsaccess blsaccess mentioned this pull request Sep 27, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tarunKoyalwar tarunKoyalwar tarunKoyalwar approved these changes

@dogancanbakir dogancanbakir Awaiting requested review from dogancanbakir

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Ice3man543 @tarunKoyalwar @ehsandeep