Skip to content

Conversation

@debasishbsws
Copy link
Contributor

Proposed changes

One of the files is using the old go-git module that has been affected by several critical and high CVE's like GHSA-449p-3h89-pw88 GHSA-mw99-9chc-xw7r

The project is already using module github.com/go-git/go-git/v5 so just removed the older version.

Checklist

  • Pull request is created against the dev branch
  • All checks passed (lint, unit/integration/regression tests etc.) with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

@debasishbsws
Copy link
Contributor Author

Need help here not sure why the test is failing?

Copy link
Member

@Mzack9999 Mzack9999 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm - I think the test error is due to some inconsistency in recent core changes. Nothing related to this PR. Nice catch and thanks for your contribution!

@Mzack9999 Mzack9999 merged commit df67578 into projectdiscovery:dev Mar 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants