Skip to content

Conversation

@Mzack9999
Copy link
Member

Proposed changes

This PR makes network final read optional, since it's up to the application protocol level to define which interactions requires a final recv operation. All C2 templates and those based only on network variables are currently broken if the server doesn't send any data.

Closes #4518

Checklist

  • Pull request is created against the dev branch
  • All checks passed (lint, unit/integration/regression tests etc.) with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

@Mzack9999 Mzack9999 self-assigned this Feb 6, 2024
@Mzack9999 Mzack9999 marked this pull request as ready for review February 7, 2024 07:19
@Mzack9999 Mzack9999 merged commit 7e108cd into dev Feb 7, 2024
@Mzack9999 Mzack9999 deleted the bugfix-4518-optional-read branch February 7, 2024 21:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

JARM Hash Issue : Nuclei not able to detect the hash

3 participants