-
Notifications
You must be signed in to change notification settings - Fork 2.9k
fix aws signer missing template variables #3206
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
$ ./nuclei -t ~/test/aws-caller.yaml -v
__ _
____ __ _______/ /__ (_)
/ __ \/ / / / ___/ / _ \/ /
/ / / / /_/ / /__/ / __/ /
/_/ /_/\__,_/\___/_/\___/_/ v2.8.7
projectdiscovery.io
[INF] Using Nuclei Engine 2.8.7 (latest)
[INF] Using Nuclei Templates 9.3.4 (latest)
[INF] Templates added in last update: 15
[INF] Templates loaded for scan: 1
[VER] [sts-get-caller-identity] Sent HTTP request to https://sts.us-east-1.amazonaws.com
[sts-get-caller-identity] [http] [info] https://sts.us-east-1.amazonaws.com
Templateid: sts-get-caller-identity
info:
name: STS get-caller-identity
author: princechaddha
severity: info
self-contained: true
signature: aws
variables:
service: sts
region: us-east-1
requests:
- raw:
- |
POST https://sts.us-east-1.amazonaws.com HTTP/1.1
Host: sts.us-east-1.amazonaws.com
Content-Type: application/x-www-form-urlencoded; charset=utf-8
User-Agent: aws-cli/2.1.28 Python/3.8.8 Darwin/21.6.0 exe/x86_64 prompt/off command/sts.get-caller-identity
Content-Length: 43
Action=GetCallerIdentity&Version=2011-06-15
matchers:
- type: word
words:
- "<GetCallerIdentityResult>"
- type: status
status:
- 200 |
|
@ehsandeep @princechaddha , Currently these variables are not evaluated before passing to aws signer, should they be evaluated ?? |
Mzack9999
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think region should default to us-east-2 if not specified (could you confirm @princechaddha )
|
Yes @Mzack9999 the default region can be |
|
I can confirm now the variables for AWS are picked up from the templates pwnmachine@Princes-MacBook-Pro nuclei % go run . -t ~/Documents/GitHub/nuclei-templates/cloud/aws/sts/aws-sts-service.yaml
__ _
____ __ _______/ /__ (_)
/ __ \/ / / / ___/ / _ \/ /
/ / / / /_/ / /__/ / __/ /
/_/ /_/\__,_/\___/_/\___/_/ v2.8.7
projectdiscovery.io
[INF] Using Nuclei Engine 2.8.7 (latest)
[INF] Using Nuclei Templates 9.3.5 (latest)
[INF] Templates added in last update: 61
[INF] Templates loaded for scan: 1
[aws-sts-service] [http] [info] https://sts.amazonaws.com |
|
@princechaddha , added following default variables any other defaults you think we should include var AwsDefaultVars = map[string]interface{}{
"region": "us-east-2",
"service": "sts",
} |
Proposed changes
closes #3202
Checklist