Skip to content

Conversation

@davidegirardi
Copy link
Contributor

@davidegirardi davidegirardi commented Nov 30, 2023

Template / PR Information

Template Validation

I've validated this template locally?

  • YES
  • NO

Additional Details (leave it blank if not applicable)

Example HTTP response body for the extraction:

{
  "server": {
    "name": "Synapse",
    "version": "1.96.1"
  }
}

Additional References:

@DhiyaneshGeek DhiyaneshGeek added Done Ready to merge good first issue Good for newcomers labels Dec 2, 2023
@DhiyaneshGeek DhiyaneshGeek self-requested a review December 2, 2023 01:59
@DhiyaneshGeek DhiyaneshGeek merged commit 120ef78 into projectdiscovery:main Dec 2, 2023
Copy link
Contributor Author

@davidegirardi davidegirardi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@DhiyaneshGeek, thanks for the merge. I'd prefer you to review my code instead of modifying it directly next time. Your changes reduced what the detector can do.

- type: word
part: body
words:
- '"name":"Synapse"'
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See above, this is not just for Synapse. Moreover, the fact that the federation endpoint under _matrix exists (at Matrix spec level) is much more robust than matching a string.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @davidegirardi , i have updated the matcher and raised a PR 8739

Let me know if it works

Thanks !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Done Ready to merge good first issue Good for newcomers

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants