Update CVE-2019-6802.yaml #8286
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated to remove false positives. As the previous change matches the words "Set-Cookie: crlfinjection=1" even if the words are present in the Location header too. The updated code, will match only if the "Set-Cookie: crlfinjection=1" is actually a header, by verifying that it actually starts in the beginning of a response header.
ehsandeep
reviewed
Sep 29, 2023
There was a problem hiding this comment.
@jainiresh thank you for improving the template, I've made minor change, can you please confirm if works as expected?
ritikchaddha
approved these changes
Oct 3, 2023
|
Hello @jainiresh, We appreciate your efforts in updating the template and making it more suitable, Your contribution has been truly valuable to us. Cheers! 🍻 |
|
Thanks for the contribution @jainiresh ! We would love to give out our swag for your contribution. Are you on our Discord channel? If not, you can join our Discord server and send a note in the |
|
Hi there,
Yes I would love to receive them.
And I have joined the discord, but I'm not able to find the #contributing
channel
…On Wed, 8 Nov, 2023, 13:37 Ritik Chaddha, ***@***.***> wrote:
Thanks for the contribution @jainiresh <https://github.com/jainiresh> !
We would love to give out our swag for your contribution. Are you on our
Discord channel? If not, you can join our Discord server
<https://discord.com/invite/projectdiscovery> and send a note in the
#contributing channel.
—
Reply to this email directly, view it on GitHub
<#8286 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ASYMYCEDT4AY66OUF72JJJ3YDM4VJAVCNFSM6AAAAAA5MDJIVCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQMBRGI4DCMJSGY>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated to remove false positives.
As the previous change matches the words "Set-Cookie: crlfinjection=1" even if the words are present in the Location header too.
The updated code, will match only if the "Set-Cookie: crlfinjection=1" is actually a header, by verifying that it actually starts in the beginning of a response header.
Template / PR Information
Template Validation
I've validated this template locally?
Additional Details (leave it blank if not applicable)
Additional References: