Fix false positive for any min.2.1.js file in crypto-mining-malware template #8246
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is a false positive for any min.2.1.js file for example some-script-min.2.1.js would be matched. According to Adguard filters the crypto miner malware is named like .n.2.1.js so we can fix this with adding a necessary point character before n. Adguard filters: https://github.com/AdguardTeam/AdguardFilters/blob/master/BaseFilter/sections/cryptominers.txt
fapami
changed the title
DhiyaneshGeek
approved these changes
Sep 23, 2023
Member
|
Hi @fapami Thank you so much for updating the template and contributing to the template project. You can join our discord server. It's a great place to connect with fellow contributors and stay updated with the latest developments. Thank you once again |
Contributor
|
Thanks for the contribution @fapami ! We would love to give out our swag for your contribution. Are you on our Discord channel? If not, you can join our Discord server and send a note in the |
Contributor
Author
|
Hi @ritikchaddha! Sorry for my late answer. I am already joined to the Discord server but with the name: fpatrik Thank you and have a nice evening |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Template / PR Information
There is a false positive for any min.2.1.js file for example some-script-min.2.1.js would be matched. According to Adguard filters the crypto miner malware is named like .n.2.1.js so we can fix this with adding a necessary point character before n.
References:
Adguard filters: https://github.com/AdguardTeam/AdguardFilters/blob/master/BaseFilter/sections/cryptominers.txt
Template Validation
I've validated this template locally?
Additional Details (leave it blank if not applicable)
Additional References: