Skip to content

Conversation

@sttlr
Copy link
Contributor

@sttlr sttlr commented Sep 19, 2023

Template / PR Information

  • Updated rdap-whois.yaml

Do not print anything upon error (when there is no information about a domain).
Use json extractor instead of regex - more reliable, fixes problems when RDAP Response isn't on one line.
Extract more fields from RDAP Response.

Template Validation

I've validated this template locally?

  • YES
  • NO

Additional Details (leave it blank if not applicable)

Additional References:

Do not print anything upon error (when there is no information about a domain).
Use json extractor instead of regex - more reliable, fixes problems when RDAP Response isn't on one line.
Extract more fields from RDAP Response.
@fmunozs
Copy link
Contributor

fmunozs commented Sep 24, 2023

Hello @sttlr ! I had not seen your PR but thank you for working on it! I noticed a lot of noise from this template recently and filled #8254

@DhiyaneshGeek DhiyaneshGeek self-assigned this Sep 27, 2023
@DhiyaneshGeek DhiyaneshGeek added good first issue Good for newcomers Done Ready to merge labels Sep 27, 2023
@princechaddha princechaddha merged commit cef5268 into projectdiscovery:main Oct 1, 2023
@DhiyaneshGeek DhiyaneshGeek linked an issue Oct 1, 2023 that may be closed by this pull request
@ritikchaddha
Copy link
Contributor

Thanks for the contribution @sttlr !

We would love to give out our swag for your contribution. Are you on our Discord channel? If not, you can join our Discord server and send a note in the #contributing channel.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Done Ready to merge good first issue Good for newcomers

Projects

None yet

Development

Successfully merging this pull request may close these issues.

rdap-whois is running on subdomains

5 participants