Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Template validation
Additional Details
Vulnerability Overview:
The vulnerability exists in Shibboleth Service Provider 3.5.0 and earlier when the replay cache is configured to use an SQL database via the ODBC plugin. Insufficient escaping of single quotes in the
SQLStringclass allows for blind SQL injection through the ID attribute of SAML responses.Detection Method:
The template uses a two-request approach to detect the vulnerability:
Template Features:
date_time()helper to satisfy SAML time window requirementsID="\' OR 1=1 -- -"Affected Systems:
CVSS Score: 9.8 (Critical)
CWE: CWE-89 (SQL Injection)
Note: This template is crafted based on the proof-of-concept from SEC Consult's security advisory. Testing on actual vulnerable systems is recommended before merge.