Skip to content

Conversation

@darses
Copy link
Contributor

@darses darses commented Jun 15, 2025

Template / PR Information

  • Remove one matcher of waf-detect:securesphere due to false positive on OPNSense error page

Template Validation

I've validated this template locally?

  • YES
  • NO

Additional Details (leave it blank if not applicable)

I did not validate on an actual SecureSphere install to check if the template still matches. Considering the words are all condition: or, I expect this to still be true.

Additional References:

- Remove one matcher of securesphere due to false positive on OPNSense error page
@princechaddha
Copy link
Member

Automated PR Review (Experimental)


Thank you for your contribution! You can join our Discord server. It's a great place to connect with fellow contributors and stay updated with the latest developments. Thank you once again.

Required Fixes:

  • The removal of the matcher '(?i)<title>error<.title>' should be reconsidered. If it's necessary to enhance the template, ensure that the remaining matchers cover the expected responses adequately.

Other Suggestions:

  • Consider providing a brief explanation in the PR description regarding why this change was made and the expected impact on false positives.
  • Ensure there are enough matchers to validate errors comprehensively without being overly reliant on a single matcher.

Please note that I am an AI Template bot and still experimental; the team will review the PR shortly.

@ehsandeep ehsandeep merged commit 35efe14 into projectdiscovery:main Jun 15, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants