Skip to content

Conversation

@darses
Copy link
Contributor

@darses darses commented Jun 14, 2025

Template / PR Information

  • Add version extract
  • Add more Shodan/Foda queries

Template Validation

I've validated this template locally?

  • YES
  • NO

Additional Details (leave it blank if not applicable)

I was not sure on how to properly add the the version extract to the same page as the panel detect, since the version is only found at another page. Currently the version checks runs only if the panel was found, and then prints the extracted version as a second entry. Example:

[mitel-micollab-panel] [http] [info] https://SNIP/portal/
[mitel-micollab-panel:version] [http] [info] https://SNIP/wd/en-us/wapplink.asp ["9.8.2.3-1"]

Another thing to note is that the current Shodan query has a false negative on pages that redirect to /server-manager/ instead of /panel/, even if the End User Portal is available. The queries add the Mitel favicon, but I expect that this also produces new false positive that were not present before.

Additional References:

- Add version extract
- Add more Shodan/Foda queries
@princechaddha
Copy link
Member

Automated PR Review (Experimental)


Thank you for your contribution! You can join our Discord server. It's a great place to connect with fellow contributors and stay updated with the latest developments. Thank you once again.

Required Fixes

  • Update the id field to represent the nature of the template, such as including the word "detect" or "panel" for better clarity.
  • Adjust the name value to follow the format: <Vendor> <Product> <Version> - Detect and specify any versions if possible.
  • Ensure that the description provides more context about what is being detected.
  • Consider adding an example of a proof of concept (P.O.C) if applicable, to align with the contribution guidelines.

Other Suggestions

  • The author field lists multiple authors but should ideally be separated by a comma appropriately; consider clarifying this if needed.
  • The shodan-query and fofa-query sections are well done with multiple queries, which can enhance the practicality of the template.
  • For better readability, consider updating the regex pattern in the extractors section to use simple strings rather than complex regex if possible.
  • Maintaining consistent indentation and spacing will improve the overall readability of the YAML file. You could use a linting tool to assist with formatting.
  • Adding a comment explaining the purpose of each matcher could further enhance clarity for future contributors reviewing this template.

Please note that I am an AI Template bot which is still experimental, and the team will review the PR shortly. Thank you!

Copy link
Member

@ehsandeep ehsandeep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Before:

[mitel-micollab-panel] [http] [info] https://14.203.224.217:443/portal/
[mitel-micollab-panel:version] [http] [info] https://14.203.224.217:443/wd/en-us/wapplink.asp ["9.8.1.102-1"]

After:

[mitel-micollab-panel:version] [http] [info] https://14.203.224.217:443/wd/en-us/wapplink.asp ["9.8.1.102-1"]

@ehsandeep ehsandeep merged commit 52c2078 into projectdiscovery:main Jun 21, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants