Fixed dsl matcher on server-private-keys. Added ed25519 to detections #11570
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks so much for your contribution @VulnScout-Chris, we appreciate it! :) |
ritikchaddha
approved these changes
Feb 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Template / PR Information
server-private-keys.yamlto properly detect these keys. Previously, the template was trying to DSL match onbody_2instead ofbody, resulting in false negative detections.id_ed25519to detections as well.Template Validation
I've validated this template locally?
Additional Details (leave it blank if not applicable)
I noticed that I wasn't getting any detections on this template at all, which led to me investigating this template closer. Changing the DSL matcher from
body_2tobody(based on documentation) gave the desired detections.Additional References: