Twitter: Broadcast twitter add / remove like and notify user when their tweet is liked#1022
Merged
itschip merged 1 commit intoproject-error:masterfrom Jul 15, 2023
Conversation
itschip
approved these changes
Jul 15, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Description
Problem:
When a tweet is liked or a like is removed from a tweet, other users do not see the tweet count changing. A user only sees the count change locally from their own like/remove like.
This PR solves this problem by broadcasting the add/remove like to all players so that the counts are accurately reflected on all clients and are kept up to date.
localToggleLiketo only handle toggling theisLikedfieldupdateTweetLikesthat is received on all clients to update thelikescount by incrementing or decrementing depending on if the like was added/removedAdditionally this PR adds a notification when a user's tweet is liked. Notifications will only show if the user is not currently looking at the twitter app.

Demo: https://clipchamp.com/watch/sEdY6bgbSMa
Note: The notification
playSoundrelies on the change presented in this PR: #1023Pull Request Checklist: