Draft HLD - Openconfig support for PortChannel interface and respective CLI's#11
Merged
Draft HLD - Openconfig support for PortChannel interface and respective CLI's#11
Conversation
Tejaswi-Goel
changed the title
Tejaswi-Goel
force-pushed
the
oc-portchannel-interface
branch
11 times, most recently
from
e1e0ed6 to
406a656
Compare
Tejaswi-Goel
force-pushed
the
oc-portchannel-interface
branch
7 times, most recently
from
ba598c4 to
b611d23
Compare
Tejaswi-Goel
force-pushed
the
oc-portchannel-interface
branch
5 times, most recently
from
d1a62a5 to
2524acb
Compare
…ive CLI's Signed-off-by: Tejaswi Goel <Tejaswi_Goel@Dell.com>
Tejaswi-Goel
force-pushed
the
oc-portchannel-interface
branch
5 times, most recently
from
1092394 to
2ec8e34
Compare
Tejaswi-Goel
force-pushed
the
oc-portchannel-interface
branch
5 times, most recently
from
4bdc507 to
72768bb
Compare
Signed-off-by: Tejaswi Goel <Tejaswi_Goel@Dell.com>
Tejaswi-Goel
force-pushed
the
oc-portchannel-interface
branch
from
72768bb to
f7962b8
Compare
Tejaswi-Goel
force-pushed
the
oc-portchannel-interface
branch
from
e67dc2a to
ada1e12
Compare
|
Hi Tejaswi, Can you please fill the "IS-CLI Compliance" table in the CLI section (3.6). Rgds, |
Tejaswi-Goel
force-pushed
the
oc-portchannel-interface
branch
2 times, most recently
from
edcef74 to
e014f3f
Compare
chaitanc
reviewed
Oct 23, 2019
Tejaswi-Goel
force-pushed
the
oc-portchannel-interface
branch
2 times, most recently
from
8d0c447 to
ea5d2f5
Compare
Signed-off-by: Tejaswi Goel <Tejaswi_Goel@Dell.com>
Tejaswi-Goel
force-pushed
the
oc-portchannel-interface
branch
from
ea5d2f5 to
bbe0af0
Compare
Reminder. Can you please get back on this. |
Signed-off-by: Tejaswi Goel <Tejaswi_Goel@Dell.com>
Tejaswi-Goel
force-pushed
the
oc-portchannel-interface
branch
4 times, most recently
from
7eaa472 to
8e308c4
Compare
Signed-off-by: Tejaswi Goel <Tejaswi_Goel@Dell.com>
Tejaswi-Goel
force-pushed
the
oc-portchannel-interface
branch
from
8e308c4 to
b846430
Compare
Collaborator
bhavini-gada
left a comment
bhavini-gada
left a comment
There was a problem hiding this comment.
Can we add "Status : Selected, true"
jangidrk
reviewed
Nov 15, 2019
| #### 3.6.2.1 Configuration Commands | ||
|
|
||
| #### Create a PortChannel | ||
| `interface PortChannel <channel-number>`<br> |
There was a problem hiding this comment.
this channel_number must be decimal/numeric.
so 2 and 02 should be treated same, which is not happening in current case.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Tejaswi Goel Tejaswi_Goel@Dell.com