Skip to content

Conversation

@pavlua
Copy link
Contributor

@pavlua pavlua commented Jul 10, 2023

fix for #77

Copy link
Member

@aensidhe aensidhe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So, it was a deliberate decision not to use ConcurrentDictionary here to reduce memory footprint. But yeah, ok, looks legit for now. CI looks broken, will need to look into it.

I'll be able to do it in late August for sure. Can't promise anything before that.

@pavlua
Copy link
Contributor Author

pavlua commented Oct 4, 2023

@aensidhe hi,
Taking into account your busyness, I have prepared a PR #90 for updating the CI process on Github Actions. Can you take a look on it pls?

@aensidhe
Copy link
Member

@pavlua please update this PR and let's merge it.

@pavlua pavlua force-pushed the fix/77-thread-safety-for-msgpackcontext branch from 7074ab7 to 81fe6ac Compare October 20, 2023 13:22
@pavlua
Copy link
Contributor Author

pavlua commented Oct 20, 2023

@aensidhe It turns out there is a problem with CI: secrets are not passed to the runner when a workflow is triggered from a forked repository (https://docs.github.com/en/actions/using-workflows/events-that-trigger-workflows#workflows-in-forked-repositories). This means that dotnet nuget push step fails, since it uses nuget API key. Possible workaround is to use 'pull_request_target' event instead of 'pull_request' in ci.yml, I'll try to investigate

@pavlua
Copy link
Contributor Author

pavlua commented Oct 23, 2023

@aensidhe hi! As I wrote you in the previous message, there are some issues with CI in the case when PR comes from forked repo (basically, my case). I made some fixes in CI in new PR #93. Please, take a look.

@aensidhe aensidhe force-pushed the fix/77-thread-safety-for-msgpackcontext branch from 81fe6ac to 42c0c78 Compare November 17, 2023 15:54
@aensidhe aensidhe enabled auto-merge (rebase) November 17, 2023 15:56
@aensidhe aensidhe force-pushed the fix/77-thread-safety-for-msgpackcontext branch from 42c0c78 to fe655e6 Compare November 17, 2023 16:44
@aensidhe aensidhe merged commit 634e847 into progaudi:master Nov 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants